[Merged by Bors] - chore(RingTheory/Smooth/Basic): fix namespace of mvPolynomial instance#39706
Closed
justus-springer wants to merge 3 commits into
Conversation
justus-springer
added
the
easy
PR summary 5da6d340caImport changes for modified filesNo significant changes to the import graph Import changes for all files
|
1 task
ocfnash
approved these changes
May 25, 2026
ocfnash
left a comment
ocfnash
left a comment
Contributor
There was a problem hiding this comment.
Thanks, just one naming tweak.
If you want to be a really good citizen you could see if there is an easy way to drop the backward.isDefEq.respectTransparency!
bors d+
Contributor
|
✌️ justus-springer can now approve this pull request. To approve and merge a pull request, simply reply with |
mathlib-triage
Bot
added
the
delegated
Co-authored-by: Oliver Nash <7734364+ocfnash@users.noreply.github.com>
justus-springer
added
the
awaiting-CI
Collaborator
Author
That's done in #39708 :) |
github-actions
Bot
removed
the
awaiting-CI
Collaborator
Author
|
bors r+ |
mathlib-bors Bot
pushed a commit
that referenced
this pull request
May 25, 2026
…nce (#39706) This instance should be in the `FormallySmooth` namespace (it currently is just `Algebra.mvPolynomial`).
Contributor
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
Bot
changed the title
mvPolynomial instancemvPolynomial instance
mathlib-bors Bot
pushed a commit
that referenced
this pull request
May 26, 2026
Define trivial `Generators` for `MvPolynomial` and use it to golf `FormallySmooth.mvPolynomial` (where they were previously defined inline). This also removes a `set_option backward.isDefEq.respectTransparency false`. - [x] depends on: #39706
b-mehta
pushed a commit
to b-mehta/mathlib4
that referenced
this pull request
Jun 2, 2026
…nce (leanprover-community#39706) This instance should be in the `FormallySmooth` namespace (it currently is just `Algebra.mvPolynomial`).
b-mehta
pushed a commit
to b-mehta/mathlib4
that referenced
this pull request
Jun 2, 2026
…ver-community#39708) Define trivial `Generators` for `MvPolynomial` and use it to golf `FormallySmooth.mvPolynomial` (where they were previously defined inline). This also removes a `set_option backward.isDefEq.respectTransparency false`. - [x] depends on: leanprover-community#39706
Bergschaf
pushed a commit
to Bergschaf/mathlib4
that referenced
this pull request
Jun 3, 2026
…nce (leanprover-community#39706) This instance should be in the `FormallySmooth` namespace (it currently is just `Algebra.mvPolynomial`).
Bergschaf
pushed a commit
to Bergschaf/mathlib4
that referenced
this pull request
Jun 3, 2026
…ver-community#39708) Define trivial `Generators` for `MvPolynomial` and use it to golf `FormallySmooth.mvPolynomial` (where they were previously defined inline). This also removes a `set_option backward.isDefEq.respectTransparency false`. - [x] depends on: leanprover-community#39706
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This instance should be in the
FormallySmoothnamespace (it currently is justAlgebra.mvPolynomial).